Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister player (in classroom module) interval and timeout on refresh #353

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Gloorf
Copy link

@Gloorf Gloorf commented Oct 3, 2017

Currently with the classroom module, events registered by an user are unregistered on reload, which is a really, really, really useful feature (as you don't need to do it yourself or refresh() if you forgot to do it yourself). Unfortunately, this doesn't apply for interval and timeout, resulting in many many refresh() to remove those old interval.

This let the classroom module unregister player-defined interval and timeout, in the same way events handlers are unregistered.

Works like player events unregister on refresh, while maintaining the
ability to clear them manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant